[EXP][CMDBUF] Add fill commands to cmd buffer experimental feature#818
Merged
kbenzie merged 1 commit intooneapi-src:mainfrom Aug 29, 2023
Merged
[EXP][CMDBUF] Add fill commands to cmd buffer experimental feature#818kbenzie merged 1 commit intooneapi-src:mainfrom
kbenzie merged 1 commit intooneapi-src:mainfrom
Conversation
EwanC
reviewed
Aug 24, 2023
Contributor
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
Mostly nitpickings, but one comment about valid inputs for patternSize parameter
Bensuo
force-pushed
the
cmd-buffer-fill
branch
2 times, most recently
from
66ebb2e to
27b39c4
Compare
kbenzie
approved these changes
Aug 25, 2023
- Adds USM and Buffer fill append commands - Update feature spec for new commands - Align naming conventions for Append* commands with core equivalents
Bensuo
force-pushed
the
cmd-buffer-fill
branch
from
27b39c4 to
40a6846
Compare
Contributor
Author
Good catch! I've just addressed these as part of this PR for simplicity, they should be well aligned now. |
veselypeta
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.